Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor site logo media panel. #67972

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

refactor site logo media panel. #67972

wants to merge 2 commits into from

Conversation

NidhiDhandhukiya74
Copy link

@NidhiDhandhukiya74 NidhiDhandhukiya74 commented Dec 13, 2024 •
edited
Loading

What?

Part of :- #67813
Part of :- #67936

Why?

Refactor "Media" panel of Site Logo block to use ToolsPanel instead of PanelBody

Testing Instructions for Keyboard

Screenshots or screencast

Before Screenshot
Before
After Screenshot

| After

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: NidhiDhandhukiya74 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 13, 2024
@github-actions GitHub Actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @NidhiDhandhukiya74! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Site Logo Affects the Site Logo Block labels Dec 13, 2024
@fabiankaegy fabiankaegy linked an issue Dec 13, 2024 that may be closed by this pull request
Refactor "Media" panel of Site Logo block to use ToolsPanel instead of PanelBody #67936
Open
@Mamaduka
Copy link
Member

I think we just need to refactor only Settings inspector controls here and leave Media as it is.

@NidhiDhandhukiya74
Copy link
Author

Hello @Mamaduka
I have refractor the settings also for site-logo.

t-hamano
t-hamano reviewed Jan 13, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

This PR seems to be expected to refactor only the Settings panel, but it looks like the Media panel has also been refactored. @NidhiDhandhukiya74 Could you check this PR again?

You might also want to address the following:

  • All controls should be visible by default for now. Add isShownByDefault to the ToolsPanelItem component.
  • The dropdown needs to be on the left. Add dropdownMenuProps to the ToolsPanel component (Example).

@Mamaduka
Copy link
Member

I started refactoring media controls to fix some accessibility issues #68621. It might be better to hold off on this change until bug fixes are merged.

@t-hamano
Copy link
Contributor

@NidhiDhandhukiya74 Now that #68621 has been merged, could you resolve the conflict for this PR?

@t-hamano t-hamano mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
[Block] Site Logo Affects the Site Logo Block First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor "Media" panel of Site Logo block to use ToolsPanel instead of PanelBody
4 participants
@NidhiDhandhukiya74 @Mamaduka @t-hamano @fabiankaegy