Remove fsevents from optionalDependencies #6792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ntwb |
ntwb
approved these changes
May 18, 2018
|
Tentatively approving and merging this PR for now I'll revisit after some further feedback from npm See also Slack chat https://wordpress.slack.com/archives/C02QB2JS7/p1526628875000089 |
ntwb
added a commit
that referenced
this pull request
May 18, 2018
4 tasks
gziolo
pushed a commit
that referenced
this pull request
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #6772
fseventswas added as an optional dependency to thepackage.json. I don't know why, but this broke our usage of gutenberg as a devDepdency for tests.See this travis build for the example pass before the pull (6772) was merged and this travis build for an example fail since the pull (6772) was merged.
How has this been tested?
I tested this by running our build against the forked version of GB (see here) and verified via the resulting travis build job that removing the
fseventsfromoptionalDependenciesfixed things for us.Checklist: