-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tag Cloud Block: Refactor settings panel to use ToolsPanel #67911
Tag Cloud Block: Refactor settings panel to use ToolsPanel #67911
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected :)
I left one minor note about also removing some now no longer needed CSS. Once that is done we can merge this 👍
CleanShot.2024-12-13.at.09.38.34.mp4
<VStack | ||
spacing={ 4 } | ||
className="wp-block-tag-cloud__inspector-settings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove this we should also remove the associated CSS which now is no longer used:
gutenberg/packages/block-library/src/tag-cloud/editor.scss
Lines 13 to 19 in cbe7ef4
.wp-block-tag-cloud__inspector-settings { | |
.components-base-control, | |
.components-base-control:last-child { | |
// Cancel out extra margins added by block inspector | |
margin-bottom: 0; | |
} | |
} |
@Sukhendu2002 actually, it looks like one of the E2E tests here needs to be updated 👍 |
Part of: #67813
What?
Refactored Tag Cloud Block code to include ToolsPanel instead of PanelBody.
Screenshots or screencast