Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Cloud Block: Refactor settings panel to use ToolsPanel #67911

Conversation

Sukhendu2002
Copy link
Contributor

Part of: #67813

What?

Refactored Tag Cloud Block code to include ToolsPanel instead of PanelBody.

Screenshots or screencast

Before After
image image

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 13, 2024 07:10
Copy link

github-actions bot commented Dec 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :)

I left one minor note about also removing some now no longer needed CSS. Once that is done we can merge this 👍

CleanShot.2024-12-13.at.09.38.34.mp4

Comment on lines -122 to -124
<VStack
spacing={ 4 }
className="wp-block-tag-cloud__inspector-settings"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove this we should also remove the associated CSS which now is no longer used:

.wp-block-tag-cloud__inspector-settings {
.components-base-control,
.components-base-control:last-child {
// Cancel out extra margins added by block inspector
margin-bottom: 0;
}
}

@fabiankaegy fabiankaegy enabled auto-merge (squash) December 13, 2024 09:08
@fabiankaegy fabiankaegy disabled auto-merge December 13, 2024 10:32
@fabiankaegy
Copy link
Member

@Sukhendu2002 actually, it looks like one of the E2E tests here needs to be updated 👍

@fabiankaegy fabiankaegy merged commit 18e4eda into WordPress:trunk Dec 13, 2024
61 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tag Cloud Affects the Tag Cloud Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Tag Cloud block to use ToolsPanel instead of PanelBody
2 participants