Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylebook: avoid double line in subcategory titles #67752

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

matiasbenedetto
Copy link
Contributor

What?

Stylebook: avoid double lines in subcategory titles

Why?

Fixes a visual regression presumably introduced in #67546

How?

CSS adjustments.

Testing Instructions

Navigate to the 'theme' tab of the stylebook and observe the titles.

Screenshots or screencast

Before After
image Screenshot from 2024-12-09 13-16-10

Copy link

github-actions bot commented Dec 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: matiasbenedetto <[email protected]>
Co-authored-by: tellthemachines <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@matiasbenedetto matiasbenedetto requested review from tellthemachines and a team December 9, 2024 16:22
@matiasbenedetto matiasbenedetto added [Type] Bug An existing feature does not function as intended [Feature] Style Book labels Dec 10, 2024
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM ✅

@jasmussen
Copy link
Contributor

The border should be above, so this is not quite right:

Screenshot 2024-12-10 at 09 13 01

Admittedly trunk looks like this:

Screenshot 2024-12-10 at 09 13 50

But the fix is to remove the "border-bottom" from here:

.edit-site-style-book__subcategory-title {
    font-size: 16px;
    margin-bottom: 40px;
    /* border-bottom: 1px solid #ddd; */
    padding-bottom: 8px;
}

That makes it look as intended:
Screenshot 2024-12-10 at 09 14 01

If you can update that, let's land this and thank you!

@matiasbenedetto
Copy link
Contributor Author

The border should be above

Fixed in the latest commit. Thanks.

image

@jasmussen
Copy link
Contributor

Nice! 🚢

@matiasbenedetto matiasbenedetto merged commit de098d9 into trunk Dec 11, 2024
62 checks passed
@matiasbenedetto matiasbenedetto deleted the fix/doble-line-stylebook-subtitle branch December 11, 2024 13:15
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Style Book [Type] Bug An existing feature does not function as intended
Development

Successfully merging this pull request may close these issues.

3 participants