Ensure contributors can create tags and manage categories #6761

danielbachhuber · 2018-05-15T21:00:58Z

Description

Ensures contributors and authors can create tags and manage categories. More specifically, this pull request:

Incorporates REST API capability changes identified in this Trac ticket. Doing so required a series of amazing hacks.
Migrates taxonomy data to core-data.
Uses wp:action-* targetSchema to expose whether or not the current user can create or assign terms for each taxonomy.

See #6361
Fixes #5879

How has this been tested?

When signed in as a contributor, you should be able to create tags and assign categories:

When signed in as an editor, you should be able to also create new categories:

Checklist:

My code is tested.
My code follows the WordPress code style.
My code follows the accessibility standards.
My code has proper inline documentation.

Ports over capability changes mentioned in Trac ticket.

pento

I can see how it was an interesting challenge to implement the PHP side of things: I left one comment, but I'm generally fine with it being super hacky in Gutenberg, as the actual core changes are fairly straightforward.

I'm not sure how I feel about all the additional processing happening in PostTaxonomies now. Maybe it'll look at little less like a wall of text once #6655 is fixed.

pento · 2018-05-16T05:13:12Z

core-data/actions.js

+export function receiveTaxonomies( taxonomies ) {
+	return {
+		type: 'RECEIVE_TAXONOMIES',
+		taxonomies: taxonomies,


This could just be taxonomies, instead of taxonomies: taxonomies.

pento · 2018-05-16T05:17:40Z

editor/components/post-taxonomies/flat-term-selector.js

@@ -174,6 +174,10 @@ class FlatTermSelector extends Component {
 		const termRemovedLabel = sprintf( _x( '%s removed', 'term' ), singularName );
 		const removeTermLabel = sprintf( _x( 'Remove %s', 'term' ), singularName );

+		if ( ! hasAssignAction ) {


It's a tiny micro-optimisation, but this check could happen immediately after hasAssignAction is declared, to avoid the processing needed to declare all the other local variables.

pento · 2018-05-16T05:18:48Z

editor/components/post-taxonomies/hierarchical-term-selector.js

@@ -242,10 +242,14 @@ class HierarchicalTermSelector extends Component {
 		const newTermSubmitLabel = newTermButtonLabel;
 		const inputId = `editor-post-taxonomies__hierarchical-terms-input-${ instanceId }`;

+		if ( ! hasAssignAction ) {


Same as in flat-term-selector.js, this check could happen earlier.

pento · 2018-05-16T05:34:45Z

lib/rest-api.php

+			&& is_array( $handler['permission_callback'] )
+			&& is_a( $handler['permission_callback'][0], 'WP_REST_Terms_Controller' ) ) {
+			// 'taxonomy' is a protected attribute, and PHP 5.2 doesn't support
+			// ReflectionProperty->setAccessible(), so we need to get really dirty.


I'm not going to lie, I'm impressed with this hack.

But, can't you get the value of ::taxonomy from the data returned by ::get_item_schema()?

But, can't you get the value of ::taxonomy from the data returned by ::get_item_schema()?

You can, in fact. I'd forgotten about that. 0c9c329

youknowriad · 2018-05-16T08:07:26Z

core-data/reducer.js

+	}
+
+	return state;
+}


Instead of adding a new reducer/selectors/actions, we could just leverage the new entities abstraction to automatically generate those. https://github.com/WordPress/gutenberg/blob/master/core-data/entities.js#L6

Currently, the entities only support fetching by id getEntityRecord but we should definitely introduce a findAll/findQuery as well getEntityRecords( state, kind, entity, query )

If you think it's too much work, it's fine to do it separately.

I'd like to handle separately (and also include more tests within core-data). I've filed an issue #6780

youknowriad · 2018-05-16T08:09:16Z

editor/components/post-taxonomies/index.js

 	const visibleTaxonomies = filter( availableTaxonomies, ( taxonomy ) => taxonomy.visibility.show_ui );
 	return visibleTaxonomies.map( ( taxonomy ) => {
 		const TaxonomyComponent = taxonomy.hierarchical ? HierarchicalTermSelector : FlatTermSelector;
+		const restBase = taxonomy.rest_base;
+		const hasCreateAction = get( post, [ '_links', 'wp:action-create-' + restBase ], false );
+		const hasAssignAction = get( post, [ '_links', 'wp:action-assign-' + restBase ], false );


Can we move these two variables inside withSelect instead?. Boolean change less often than a objects which avoid rerenders.

Oh I guess it's per taxonomy, This is for me an indication that these checks should be moved to the TaxonomyComponent instead.

Moved in 04aa6e5

danielbachhuber · 2018-05-16T13:47:41Z

@youknowriad @pento Good to go now.

youknowriad

LGTM for the JS part of things. I'll defer to @pento for the endpoint updates.

tofumatt · 2018-05-17T03:31:42Z

FYI I'm away on holiday for the next week or so; feel free to un-assign me for review and have someone else take a look. Otherwise I can have a look come May 28-ish...

pento

Noice. Let's do it.

aduth · 2018-05-23T19:55:37Z

editor/components/post-taxonomies/flat-term-selector.js

 		return {
+			hasCreateAction: get( getCurrentPost(), [ '_links', 'wp:action-create-' + ownProps.restBase ], false ),


Should this logic be its own selector? Something like canUserForPost( actionType, restBase ) ?

Minor: getCurrentPost as implemented is trivial, though nothing guarantees it is, in which case assigning a single variable of const currentPost = getCurrentPost() to use across the two merged props would be marginally more performant.

Should this logic be its own selector? Something like canUserForPost( actionType, restBase ) ?

See #6655

Ensure contributors can create tags and manage categories

89efbff

Ports over capability changes mentioned in Trac ticket.

danielbachhuber added this to the 2.9 milestone May 15, 2018

danielbachhuber added 5 commits May 15, 2018 14:18

An even worse workaround for PHP 5.2 compatibility

c4e4875

Expose wp:action-assign-tags and related actions

fa464ea

Move taxonomy data management to core-data

fd531a0

Fix linting for fd531a0

39b61b5

Defer to wp:action-* when determining which UI to display

a25c474

danielbachhuber changed the title ~~[WIP] Ensure contributors can create tags and manage categories~~ Ensure contributors can create tags and manage categories May 15, 2018

danielbachhuber requested a review from a team May 15, 2018 23:59

danielbachhuber mentioned this pull request May 16, 2018

Permit unbounded per_page=-1 requests for Categories and Tags #6722

Merged

4 tasks

danielbachhuber requested review from tofumatt and pento May 16, 2018 00:10

pento reviewed May 16, 2018

View reviewed changes

youknowriad reviewed May 16, 2018

View reviewed changes

youknowriad modified the milestones: 2.9, 3.0 May 16, 2018

danielbachhuber added 4 commits May 16, 2018 06:30

Use a much less hacky way to access the taxonomy

0c9c329

Simplify statement

9a96bed

Move conditional earlier to avoid processing

ac803ad

Move checks into corresponding TaxonomyComponent

04aa6e5

danielbachhuber mentioned this pull request May 16, 2018

Leverage getEntityRecord when getting taxonomies from core-data #6780

Closed

youknowriad reviewed May 16, 2018

View reviewed changes

Fix PHPCS issues

92a1945

pento approved these changes May 17, 2018

View reviewed changes

pento modified the milestones: 3.0, 2.9 May 17, 2018

pento merged commit 304302f into master May 17, 2018

pento deleted the 5879-term-capabilities branch May 17, 2018 07:29

aduth reviewed May 23, 2018

View reviewed changes

danielbachhuber mentioned this pull request Jul 3, 2018

Categories and tags are hidden if role is author or lower #7662

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure contributors can create tags and manage categories #6761

Ensure contributors can create tags and manage categories #6761

danielbachhuber commented May 15, 2018 •

edited

Loading

pento left a comment

pento May 16, 2018

danielbachhuber May 16, 2018

pento May 16, 2018

danielbachhuber May 16, 2018

pento May 16, 2018

danielbachhuber May 16, 2018

pento May 16, 2018

danielbachhuber May 16, 2018

youknowriad May 16, 2018

danielbachhuber May 16, 2018

youknowriad May 16, 2018 •

edited

Loading

youknowriad May 16, 2018

danielbachhuber May 16, 2018

danielbachhuber commented May 16, 2018

youknowriad left a comment

tofumatt commented May 17, 2018

pento left a comment

aduth May 23, 2018

danielbachhuber May 23, 2018

		return {
		hasCreateAction: get( getCurrentPost(), [ '_links', 'wp:action-create-' + ownProps.restBase ], false ),

Ensure contributors can create tags and manage categories #6761

Ensure contributors can create tags and manage categories #6761

Conversation

danielbachhuber commented May 15, 2018 • edited Loading

Description

How has this been tested?

Checklist:

pento left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youknowriad May 16, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielbachhuber commented May 16, 2018

youknowriad left a comment

Choose a reason for hiding this comment

tofumatt commented May 17, 2018

pento left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danielbachhuber commented May 15, 2018 •

edited

Loading

youknowriad May 16, 2018 •

edited

Loading