Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Make lerna a dependency rather than a devDependency #6752

Merged
merged 1 commit into from
May 15, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 15, 2018

Description

Closes #6718 raised by @nerrad.

I guess it's a temporary solution until we have all packages published.

In general, you shouldn't need to do it. You can double check looking at package.json files from Babel, Jest or create-react-app.

How has this been tested?

npm i still works.

@gziolo gziolo added the [Type] Build Tooling Issues or PRs related to build tooling label May 15, 2018
@gziolo gziolo added this to the 2.9 milestone May 15, 2018
@gziolo gziolo self-assigned this May 15, 2018
@gziolo gziolo requested a review from ntwb May 15, 2018 07:22
@gziolo
Copy link
Member Author

gziolo commented May 15, 2018

Lerna has impressive number of dependencies :)

@gziolo gziolo merged commit 821be2e into master May 15, 2018
@gziolo gziolo deleted the fix/6718-lerna branch May 15, 2018 07:30
@nerrad
Copy link
Contributor

nerrad commented May 15, 2018

Thanks for doing this, I can confirm it fixes the issue I reported. I'm curious what this statement means though:

You can double check looking at package.json files from Babel, Jest or create-react-app

It seems like something that would be handy knowledge to have.

@ntwb
Copy link
Member

ntwb commented May 15, 2018

@nerrad Once we have all the things published to https://www.npmjs.com/org/wordpressand working as expected we should be able to remove Lerna from dependencies back to devDependencies as you will be able to inspect the various package.json files and only require the packages you need to require rather than all of Gutenberg as is the case for you right now.

p.s And we will update the docs on how to do this then also

@gziolo
Copy link
Member Author

gziolo commented May 15, 2018

Yes, what @ntwb explained, thanks 🙇

@nerrad
Copy link
Contributor

nerrad commented May 15, 2018

Ahh gotcha, I was already aware of that but didn't realize that's what was being referred to. Thanks for clarifying 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants