Site Editor: show pattern category step in navigation for mobile #67505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ramonjd
added
[Type] Bug
ramonjd
commented
Dec 3, 2024
| @@ -155,9 +155,10 @@ function Layout() { | |||
| isResizableFrameOversized | |||
| } | |||
| /> | |||
| { areas.mobile } | |||
There was a problem hiding this comment.
TODO: add an inline comment explaining what's going on here.
// The mobile sidebar needs access to the SidebarNavigationContext.Provider inside SidebarContent .
|
Size Change: +50 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e6d7551. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12151813691
|
…ebar in sitecontent to get the context, also rendering edit mode.
ramonjd
force-pushed
the
try/site-editor-sidebar-navigation-mobile
branch
from
f75d6c2 to
990a1c9
Compare
…outes/templates.js as they're taken care of in #67547
ramonjd
changed the title
Ensure template parts can be accessed from the patterns sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
So that users can access template parts in mobile view from the patterns panel, show the patterns category list.
Props to @t-hamano for the nudge.
See: #67460 (comment)
Note
There is a known inconsistency in the WP logo navigation: when you enter the data view for a patterns category, the WP logo takes you back to the main Design menu (not back a step).
Why?
In themes such as TT4, the "All patterns" view won't show the template parts and are therefor inaccessible.
How?
Checking for postType and categoryId. If it's there, show
<PagePatterns />.Testing Instructions
Screenshots or screencast
Before
Kapture.2024-12-04.at.13.25.01.mp4
After
Kapture.2024-12-04.at.13.20.51.mp4