Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade TypeScript to 5.7 and fix types #67461

Merged
merged 6 commits into from
Dec 6, 2024

Conversation

manzoorwanijk
Copy link
Member

Supercedes #65487

What?

  • Update TypeScript to 5.7.2
  • Fix types errors

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

  • CI should be happy

Screenshots or screencast

Copy link

github-actions bot commented Dec 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <[email protected]>
Co-authored-by: gziolo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@gziolo gziolo added the [Type] Build Tooling Issues or PRs related to build tooling label Dec 5, 2024
@gziolo gziolo requested review from sirreal and jsnajdr December 6, 2024 05:25
@gziolo
Copy link
Member

gziolo commented Dec 6, 2024

As we are on this one, can we also increase the minimum required version of TypeScript in the ESLint config package?

@manzoorwanijk
Copy link
Member Author

increase the minimum required version of TypeScript in the ESLint config package

Done. Thanks

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The only thing I’m not sure is whether the change fir ESLint config should be flagged as breaking in the changelog.

@manzoorwanijk
Copy link
Member Author

The only thing I’m not sure is whether the change fir ESLint config should be flagged as breaking in the changelog.

Yeah, it should be a breaking change. I have updated the changelog accordingly.

@manzoorwanijk manzoorwanijk requested a review from gziolo December 6, 2024 06:28
@gziolo
Copy link
Member

gziolo commented Dec 6, 2024

@youknowriad, could you promote @manzoorwanijk to the Gutenberg repository member so he doesn't have to use forks? He had enough commits to qualify for quite some time.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes locally and everything works correctly.

@gziolo gziolo merged commit 15bff41 into WordPress:trunk Dec 6, 2024
61 of 64 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 6, 2024
@youknowriad
Copy link
Contributor

Invite sent for the repo, thanks for all the contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants