-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade TypeScript to 5.7 and fix types #67461
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
As we are on this one, can we also increase the minimum required version of TypeScript in the ESLint config package?
|
Done. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The only thing I’m not sure is whether the change fir ESLint config should be flagged as breaking in the changelog.
Yeah, it should be a breaking change. I have updated the changelog accordingly. |
@youknowriad, could you promote @manzoorwanijk to the Gutenberg repository member so he doesn't have to use forks? He had enough commits to qualify for quite some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes locally and everything works correctly.
Invite sent for the repo, thanks for all the contributions. |
Supercedes #65487
What?
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast