-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Group Block Placeholder Design and Accessibility for Consistency with Other Blocks #67083
base: trunk
Are you sure you want to change the base?
Enhance Group Block Placeholder Design and Accessibility for Consistency with Other Blocks #67083
Conversation
…scribedby attributes & improved labels
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @sarthaknagoshe2002! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
@ellatrix Could you please review this PR? |
Thanks for the PR! Design-wise, it's not clear that the icon and label helps this state, and the removal of the label and icon was intentional:
The placeholder's original design did not consider all the contexts in which it was used, and so rather than regressing the Group block to a past design, it seems more friutful to consider how we can refresh the other placeholders to scale better to additional contexts. |
@jasmussen I’d like to propose adding these changes along with some additional updates suggested in #54867. This will help ensure placeholders are present, maintain consistency, and ensure that when adding to narrow layouts, the selection appears in the block controls. |
@jasmussen while I do understand the need to make the placeholder scale well in narrow spaces, I'm not sure you are fully understanding the users needs, the accessibility requirements, and the technologies we have to support. A visible label is needed to visually expose the accessible name of the variations. Please keep into consideration all the devices and technologies users use, thanks. |
Fixes: #66062
What?
This PR improves the placeholder UI and accessibility of the Group block to align it with other blocks (e.g., Columns, Query Loop); refer #66062. It addresses the following:
aria-describedby
.Why?
aria-describedby
attributes.How?
Design Consistency:
Accessibility Improvements:
aria-describedby
attributes, ensuring accessible names match the visible text.Testing Instructions
Verify Design Consistency:
Compare Placeholders:
Accessibility Testing:
aria-describedby
attribute is present and correctly associates the title and description.Screenshots or screencast
Before
After
aria-describedby label