Query and Search blocks: support for Instant Search via render_block_context filter
#67013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalczaplinski
requested review from
spacedmonkey and
ajitbohra
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ktmn. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
michalczaplinski
added
[Block] Search
|
Size Change: +457 B (+0.03%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
michalczaplinski
added
[Type] Experimental
michalczaplinski
changed the title
render_block_context filter
|
Flaky tests detected in db5f965. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12036199277
|
|
Closing in favor of #67181. There is nothing obviously wrong with this approach, but using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An implementation of the instant search using the Query and Search blocks. Please see #63147 for a full description.
An alternative to #63147 and #67181.
Fixes #63053.
Why?
The approach in the current PR is more concise and reduces the repetitive code compared to #63147.
How?
Using
render_block_contextto inject the relevant search query into the context. See also this comment for more context.Testing Instructions and screencast
See #63147.