Templates: hide media field in list view #66573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
requested review from
youknowriad,
mcsf,
jameskoster and
ntsekouras
oandregal
added
[Type] Enhancement
|
Size Change: -48 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a80cf3d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11579808523
|
ntsekouras
approved these changes
Oct 30, 2024
| ) : ( | ||
| <div className="dataviews-view-list__media-placeholder"></div> | ||
| ); | ||
| <div className="dataviews-view-list__media-wrapper"> |
There was a problem hiding this comment.
This removes the placeholder in all lists, right?
I'm wondering why we needed an empty placeholder before though, because it would only be rendered if we hadn't provided mediaField and wouldn't check if the result of the render. 🤔
There was a problem hiding this comment.
Yeah, it removes it when the consumer doesn't provide a mediaField, while before we'd render a placeholder.
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
) Co-authored-by: oandregal <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hide the media field in the list view of the Templates page:
Why?
It hasn't proven very valuable to render the page preview in the little space given to the media field.
How?
mediaFieldoptional for list layout ee55aa1mediaFieldto the list layout a80cf3dTesting Instructions