Revert 66431 (Site editor: remove "default" admin CSS) #66540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Regression
andrewserong
requested review from
draganescu
and removed request for
a team and
spacedmonkey
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
added
the
No Core Sync Required
tellthemachines
approved these changes
Oct 28, 2024
|
Thanks for the quick reviews! 🙇 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: andrewserong <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: tellthemachines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #66431
Why?
While a well-intentioned change to remove unnecessary CSS, it turns out #66431 caused a regression in the site editor in mobile viewport sizes where the admin markup is exposed unexpectedly.
A longer-term solution might be to see if we can skip the admin markup entirely for
site-editor.php, however for now, in order to ensure things are working well ontrunk, this PR proposes reverting.How?
Revert the change in #66431
Testing Instructions
trunkopen up the site editor in a mobile viewport size. Notice that above the content of the site editor the WP admin UI markup is unexpectedly displayed.Screenshots or screencast