Fix zoom out shortcut on Windows #66506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
I am using Windows 11 with my OS set to Swedish. I can confirm that the new combination turns on and off the zoom out. |
ntsekouras
approved these changes
Oct 29, 2024
Mamaduka
approved these changes
Oct 29, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: ntsekouras <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: torounit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #66400
Fixes #66449
What?
This PR fixes the zoom-out toggle shortcut to work on Windows OS.
Why?
As explained in this comment,
primaryShift + 0 (ctrl + shift + 0)may not work on Windows OS with IME enabled.How?
From my research, there are four possible new key combinations:
Shift + 0 (shift + 0)Alt + 0 (alt + 0)Ctrl + Alt + 0 (primaryAlt + 0)Ctrl + Shift + Alt + 0 (secondary + 0)Of these, I chose
Ctrl + Shift + Alt + 0, which is similar to the full-screen mode toggle shortcut (Ctrl + Shift + Alt + F):Testing Instructions
I would be happy if someone could test this PR on Windows OS, but I would also be happy if someone could at least test it on MacOS to make sure the shortcuts work as before.
Screenshots or screencast
ef11db06f202a19e6cb8eeabb810a02d.mp4