Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Fix React Compiler error for 'useAutocomplete' #66496

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Mamaduka
Copy link
Member

What?

Part of #61788.
Similar to #66464.

Resolves anti-mutation React Compiler error for the useAutocomplete hook.

Why?

We're renaming some refs, so their name ends inRef. This is necessary for the enableTreatRefLikeIdentifiersAsRefs config flag of the React Compiler to work well.

Testing Instructions

It shouldn't be necessary. This is a code style change.

@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Oct 26, 2024
@Mamaduka Mamaduka self-assigned this Oct 26, 2024
@Mamaduka Mamaduka requested a review from ajitbohra as a code owner October 26, 2024 04:16
@Mamaduka Mamaduka requested a review from tyxla October 26, 2024 04:16
Copy link

Flaky tests detected in 1832456.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11528833995
📝 Reported issues:

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mamaduka 🚀

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka merged commit ba17e59 into trunk Oct 29, 2024
70 of 72 checks passed
@Mamaduka Mamaduka deleted the fix/use-autocomplete-compiler-error branch October 29, 2024 03:34
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 29, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants