Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Link: Add Border and Spacing support #66483

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link

What?

Add border and spacing block support to the Navigation Link( Custom Link ) block.

Part of #43247
Part of #43243

Why?

Navigation Link( Custom Link ) block is missing border and spacing support.

How?

Adds the border and spacing block support in block.json

Testing Instructions

  • Go to Appearance > Editor > Styles > Edit Styles > Blocks.
  • Ensure the Navigation Link( Custom Link ) block’s border and spacing are configurable via Global Styles.
  • Confirm Global Styles apply correctly in both the Editor and Frontend.
  • Open the Page or Template where you want to add the menu.
  • Add a Navigation block (the container block for all navigation links).
  • If WordPress detects pre-existing menus, it may prompt you to start with an existing menu. Choose Create a new menu if starting fresh.
  • Within the Navigation block, select any pre-existing page links.
  • That is the Navigation Link( Custom Link ) block and the block name could be a Custom Link, Post Link, Page Link, Category Link, or Tag Link, depending on its type.
  • Verify Border, Radius, and Spacing settings are available for this link.
  • Check that block-specific styles (e.g., borders, spacing) take precedence over Global Styles.
  • Ensure borders and spacing display correctly in both the Editor and Frontend.

Testing Instructions for Keyboard

Screenshots or screencast

In Backend:
navigation_link_backend

In Frontend:
navigation_link_frontend

Copy link

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Oct 25, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @karthick-murugan! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant