Editor: Multi-entity saving: Show correct count of entities to be saved #66482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal was incorrectly displaying the number of different *types* of entities to be saved. This result was inconsistent with the actual list of entities rendered underneath and with the "Review _n_ changes" label on the left-hand sidebar.
mcsf
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Oct 25, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ed (WordPress#66482) The modal was incorrectly displaying the number of different *types* of entities to be saved. This result was inconsistent with the actual list of entities rendered underneath and with the "Review _n_ changes" label on the left-hand sidebar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix the count of unsaved entities in the multi-entity saving UI:
The modal was incorrectly displaying the number of different types of entities to be saved. In the scenario above, it was incorrectly reporting 3 unsaved changed, because there were three types thereof (Site, Template, Template Part).
This result was inconsistent with the actual list of entities rendered underneath, as well as with the "Review n changes" label on the left-hand sidebar.
For reference, the bug was introduced in #58706.
How?
Read directly from the "source", i.e. the
dirtyEntityRecordsarray available as component props. Disregard the value ofsortedPartitionedSavables, which is a grouping of records obtained fromdirtyEntityRecordsand keyed by entity name.Testing Instructions