Don't switch editor mode when changing entities #66452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -30 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
This seems like a left over from my refactoring PR or maybe these were introduced afterwards/at the same time. |
youknowriad
approved these changes
Oct 25, 2024
I think these were accidentally introduced trying to fix both 6.7 and |
getdave
changed the title
|
Thank you! This was also triggering the REST API request on load |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Only reset zoom level * Avoid set editor mode on sidebar toggle Co-authored-by: getdave <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Ella <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
wp/6.7. This PR is incompatible with that branch.Avoid REST API call caused by resetting editor mode on:
WsidebarWhy?
In
trunkthe editorMode is now a preference. That means changing it will trigger a REST request.Props to @ellatrix for spotting this one.
Moreover, the Zoom Out is no longer coupled to editorMode. Rather it relies solely on
zoomLevelstate. Therefore this call is redundant intrunk(only!).This is all predicated on the assumption that we do not wish to reset a user activate preference when moving between entities in the Editor.
How?
Removes the call to set the editor mode in the relevant portions of code.
Testing Instructions
First verify the bug.
trunkNetworkand filter by search stringrest_route=%2Fwp%2Fv2%2Fusers%2Fm. This is the REST request to the user preferences endpoint.Wto activate left hand sidebarPagesclick between a few pages and then click on the canvas to edit any page.Backbutton. See the network request triggered as you move between Pages.Now check this branch resolves.
Wsidebar or move between entities.Testing Instructions for Keyboard
Screenshots or screencast