Site editor: Fix save shortcut #66423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
mcsf
reviewed
Oct 24, 2024
Comment on lines
84
to
85
| { canvas === 'view' && <KeyboardShortcutsRegister /> } | ||
| <KeyboardShortcutsGlobal /> |
There was a problem hiding this comment.
- IMO we can improve the naming. "Global" shouldn't be part of the labels, since we're always dealing with the same editor-wide shortcuts. It's more "define" vs. "activate", "register" vs. "enqueue", etc. No?
There was a problem hiding this comment.
I don't get your suggestion for a better name. Can you provide an example?
I thought about it and while I thought it could include more shortcuts in the future, since it's internal components we can rename to be specific for save now.
After all these cases should be rare with the unification of the editors.
Also you comment made me think that KeyboardShortcutsGlobal should be under the same view check. I'll retest and push.
There was a problem hiding this comment.
Is this component just about the "save" shortcut? because while we want the "save" shortcut just for "view" canvas, we might want others in all modes. So I'd actually move the check to within the component or rename it "SaveShortcut" or something.
There was a problem hiding this comment.
For now I'll rename to SaveKeyboardShortcut and have a single file. If we need other site editor shortcuts let's create that folder then.
There was a problem hiding this comment.
The separation in rendering the two components looked so intentional that I read between the lines and assumed it was a performance concern (i.e. define the shortcut once, then toggle it more cheaply according to view). I should have not assumed and should have just asked. :)
The new setup with SaveKeyboardShortcut is much clearer, and I appreciate the YAGNI spirit.
There was a problem hiding this comment.
The intention was for the shortcut to always be available in the global "keyboard shortcuts" modal regardless of whether it was active or not.
ntsekouras
commented
Oct 24, 2024
Comment on lines
+58
to
+64
| if ( ! hasDirtyEntities || isSaving ) { | ||
| return; | ||
| } | ||
| if ( hasNonPostEntityChanges() ) { | ||
| setIsSaveViewOpened( true ); | ||
| } else if ( ! isPostSavingLocked() ) { | ||
| savePost(); |
There was a problem hiding this comment.
These are the main changes from the old file.
|
I pushed 2c57e6d because "shortCut" is just weird :) Other than that, looks good to me! |
mcsf
approved these changes
Oct 28, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ntsekouras <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
While working on some shortcuts issue I noticed that we in site editor we register the
Save your changes.twice. There is a reason for needing a special save shortcut in site editor which is to handle saving when we are inviewmode.This PR fixes two issues:
Save your changesshortcut is only registered in view mode and therefore is not duplicate in the respective list in the dialog.Screenshots
Check the
Save your changes.command(s).Previously, I believe issue
number 1used to work and probably the code was somehow reorganised. Not that it matters much..Testing Scenarios in site editor
viewmode without saving. The shortcut for save should work properly.viewmode without saving. Make changes to a second entity and go back to view mode. The shortcut should open thedialogto save.