Make useZoomOut hook private #66374
Merged
Make useZoomOut hook private #66374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
jeryj
force-pushed
the
update/make-use-zoom-out-private
branch
from
32b82e5 to
e6e248c
Compare
jeryj
added
[Feature] Zoom Out
[Type] Code Quality
|
Size Change: +2 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Oct 23, 2024
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
jeryj
added a commit
that referenced
this pull request
Oct 23, 2024
Co-authored-by: jeryj <[email protected]> Co-authored-by: Mamaduka <[email protected]>
kevin940726
pushed a commit
that referenced
this pull request
Oct 24, 2024
Co-authored-by: jeryj <[email protected]> Co-authored-by: Mamaduka <[email protected]>
kevin940726
added
Backported to WP Core
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: jeryj <[email protected]> Co-authored-by: Mamaduka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Move useZoomOut hook to be private
Why?
It was never intended to be public, and it's agreed that it is not ready or needed to be public at the moment as it's unstable and changes quickly. It's unlikely to be in use by a third party right now.
How?
Remove it from public apis, move to private apis.
Testing Instructions
Inserter:
Styles:
Testing Instructions for Keyboard
Screenshots or screencast