Plugins: Deprecate 'withPluginContext' HOC #66363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Plugins API
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
approved these changes
Oct 23, 2024
|
Size Change: +53 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
deprecate/with-plugin-context
branch
from
fa3891c to
91a31d6
Compare
Mamaduka
force-pushed
the
deprecate/with-plugin-context
branch
from
91a31d6 to
e682f68
Compare
gziolo
reviewed
Oct 23, 2024
gziolo
approved these changes
Oct 23, 2024
Co-authored-by: Greg Ziółkowski <[email protected]>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: gziolo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR deprecated the
withPluginContextHOC in favor of the "new"usePluginContexthook.Why?
Using the context hook should be preferred over HOC and finished work I started in #53291.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast