Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Badge Color contrast #66360

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix : Badge Color contrast #66360

merged 1 commit into from
Oct 24, 2024

Conversation

Vrishabhsk
Copy link
Contributor

@Vrishabhsk Vrishabhsk commented Oct 23, 2024 •
edited by afercia
Loading

Fixes #66322

What?

Why?

How?

  • Change text-color for post list title and post card title badge to $gray-800

Screenshots or screencast

Posts Page Homepage Posts List
Screenshot 2024-10-23 at 12 59 42 PM Screenshot 2024-10-23 at 12 59 49 PM Screenshot 2024-10-23 at 12 59 59 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Vrishabhsk <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Vrishabhsk Vrishabhsk mentioned this pull request Oct 23, 2024
Closed
6 tasks
@afercia afercia added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Package] Edit Site /packages/edit-site labels Oct 23, 2024
@afercia
Copy link
Contributor

afercia commented Oct 23, 2024

From an accessibility perspective, looks good to me.
Cc @WordPress/gutenberg-design for feedback on the visual change.

@jameskoster
Copy link
Contributor

Thank you.

Side note: it would be good to create a component for badges.

@afercia
Copy link
Contributor

afercia commented Oct 24, 2024

Side note: it would be good to create a component for badges.

Thanks for your feedback @jameskoster. I'd totally support standardising badges in a component if there are plans to use them more often.

@afercia afercia merged commit 9c7847d into WordPress:trunk Oct 24, 2024
72 of 76 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 24, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
@Vrishabhsk @jameskoster
@afercia @karthick-murugan
Change text color to gray-800 to improve color contrast (WordPress#66360
4a1711c 
)


Co-authored-by: Vrishabhsk <[email protected]>
Co-authored-by: jameskoster <[email protected]>
Co-authored-by: afercia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameskoster jameskoster jameskoster approved these changes

@oandregal oandregal Awaiting requested review from oandregal

@afercia afercia Awaiting requested review from afercia

Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Edit Site /packages/edit-site [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 19.6
Development

Successfully merging this pull request may close these issues.

Insufficient color contrast for the post list title badge and the post card title badge
3 participants
@Vrishabhsk @afercia @jameskoster