Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Improve the DocumentBar post type label for the Homepage and Posts Page cases #66355

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Fix: Improve the DocumentBar post type label for the Homepage and Posts Page cases #66355

merged 8 commits into from
Oct 29, 2024

Conversation

hbhalodia
Copy link
Contributor

@hbhalodia hbhalodia commented Oct 23, 2024 •
edited by afercia
Loading

Fixes #66320

What?

  • This PR adds the utility custom hook to add the badge to the editor view in post panel and docuemnt bar.

Why?

How?

  • PR adds the utility custom hook to get the details and add the badge based on the details.

Testing Instructions

Testing Instructions for Keyboard

  • None.

Screenshots or screencast

Screenshot 2024-10-23 at 12 34 35 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: Vrishabhsk <[email protected]>
Co-authored-by: afercia <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@hbhalodia hbhalodia requested a review from afercia October 23, 2024 07:08
@afercia afercia added [Type] Bug An existing feature does not function as intended [Package] Editor /packages/editor Needs Design Feedback Needs general design feedback. labels Oct 24, 2024
afercia
afercia requested changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well for me, thanks @hbhalodia.
I left a few minor comments to address.

@hbhalodia
Copy link
Contributor Author

Tests well for me, thanks @hbhalodia. I left a few minor comments to address.

Thanks @afercia, I would look on those and address the same.

@afercia
Copy link
Contributor

afercia commented Oct 28, 2024

@hbhalodia looks good to me, thanks. Can you please solve the merge conflict, when you have a chance?

@hbhalodia
Copy link
Contributor Author

@hbhalodia looks good to me, thanks. Can you please solve the merge conflict, when you have a chance?

Sure, @afercia, I would fix those.

@hbhalodia
Copy link
Contributor Author

Hi @afercia, I have resolved the conflicts and do checked from my end all looks good, Can you please have a final look as well, if anything missed while resolving conflicts 🙇.

Thank You,

afercia
afercia approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@afercia afercia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hbhalodia, looks good to me

@afercia afercia merged commit 7ca9567 into WordPress:trunk Oct 29, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.6 milestone Oct 29, 2024
karthick-murugan pushed a commit to karthick-murugan/gutenberg that referenced this pull request Nov 13, 2024
@hbhalodia @afercia @karthick-murugan
Fix: Improve the DocumentBar post type label for the Homepage and Pos…
a952ff0 
…ts Page cases (WordPress#66355)

* Add the correct consistent label on document bar

* Add the utililty custom hook to get the page badge based on current view

* Change the variable name to be more precise

* Update the document bar label display logic

* Address the PR feedbacks

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: Vrishabhsk <[email protected]>
Co-authored-by: afercia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afercia afercia afercia approved these changes

@Vrishabhsk Vrishabhsk Awaiting requested review from Vrishabhsk

Assignees
No one assigned
Labels
Needs Design Feedback Needs general design feedback. [Package] Editor /packages/editor [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 19.6
Development

Successfully merging this pull request may close these issues.

Improve the DocumentBar post type label for the Homepage and Posts Page cases
3 participants
@hbhalodia @afercia @Vrishabhsk