VisualEditor: Remove wide and full alignment CSS on the root container #66352
+1
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
Size Change: -122 B (-0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 23, 2024
| @@ -272,7 +272,7 @@ function VisualEditor( { | |||
| 'is-layout-flow': ! themeSupportsLayout, | |||
| }, | |||
| themeSupportsLayout && postContentLayoutClasses, | |||
| align && `align${ align }` | |||
| align && ! [ 'wide', 'full' ].includes( align ) && `align${ align }` | |||
There was a problem hiding this comment.
Any reason to keep left/right/center alignments?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #52163. Note, this does not fix #60311 which had the opposite feedback. If this PR lands, we'll effectively be saying that #60311 is a "won't fix" 🙂
This PR proposes removing the wide and full alignment CSS on the root container of the visual editor. I'm happy to close out this PR if it isn't a desired path forward.
Why?
This CSS was in place so that the post and page editors could more closely resemble how a post might look in the context of a template. However, ever since the editors were unified, it's possible for users to switch on template preview mode (or in the case of page editing in the site editor, switch it off). In #52163 the feedback / discussion is that displaying post content full width in the post and page editors isn't a WYSIWYG experience and can make the editor feel broken.
The suggestion there was to remove the behaviour that detects wide / full width alignment and attempts to display content to the wide / full sizes in the post editor. Note: for posts and pages that use templates that do use content width, wide and full alignments should still be available within the post content, so for example setting a Cover or Group block to wide or full in regular templates should work as before.
How?
alignCSSrules that attempted to make the editor (with template preview switched off) look more WYSIWYGalignclassname if it isn'twideorfull(so left or right aligned content still works as before)Testing Instructions
Single item: PostBefore
Note: on
trunk, in this case, the content would have displayed edge-to-edge in the post editor: