Zoom Out: Remove double click to exit hook from the block-editor package #66335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -34 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Oct 23, 2024
| @@ -112,7 +111,6 @@ export function useBlockProps( props = {}, { __unstableIsHtml } = {} ) { | |||
| useBlockRefProvider( clientId ), | |||
| useFocusHandler( clientId ), | |||
| useEventHandlers( { clientId, isSelected } ), | |||
| useZoomOutModeExit(), | |||
There was a problem hiding this comment.
Good question, why was it added here? It's good to avoid adding hooks to every block if we can capture the event higher up.
There was a problem hiding this comment.
And the other one in the editor package was added here more recently: #65963
There was a problem hiding this comment.
@andrewserong Any reason you left the other one in place?
There was a problem hiding this comment.
Thanks for the ping! Nope, I left it there by accident as there were a couple of iterations on the approach. Thanks for following up!
ellatrix
approved these changes
Oct 23, 2024
youknowriad
deleted the
update/remove-zoom-out-double-click-from-block-refs
branch
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…age (WordPress#66335) Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #50739
What?
Ideally the zoom level of the block editor should be something that you can enforce from the settings of the editor. But to be able to do so, we need to move any "smart" behavior that exists zoom-out from the block-editor package.
Also, I noticed that the
useZoomOutModeExithook is applied into places (potentially duplicate). Do we know why it was applied on the block ref at all?This PR attempt to remove that duplication but I'm not entirely sure what impact it has. The goal being no impact at all.
Testing Instructions
1- Try double click to exit zoom out.