-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update a few function definitions #66315
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
It's werid that those function definitions caused problems in the first place. Maybe we should open an issue with the @typescript-eslint/typescript-estree
project
Will do 👍 |
Looks like it's been a known issue for a while: typescript-eslint/typescript-eslint#1236 |
Flaky tests detected in 1257cce. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11458582363
|
1257cce
to
6980ce8
Compare
Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
What?
Changing a few arrow functions to be regular functions.
Why?
To unblock #65463.
For some reason
@typescript-eslint/typescript-estree
breaks parsing those constructs when an arrow function is used, while using a regular function works well.When fixing those, we're able to run
react-scanner
properly without it failing on those functionsHow?
We're just changing a few arrow functions to be proper functions, the rest is the same
Testing Instructions
npm install
npm run component-usage-stats > stats.json
git cherry-pick 1257ccef14c3e0165a71a1195237ec37724f0273
to get the commit from this branch.npm run component-usage-stats > stats.json
Testing Instructions for Keyboard
Same
Screenshots or screencast
Errors we see with #65463: