SpacingSizesControl: Use generic label for linked button #66304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -29 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
madhusudhand
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks for taking care of this @t-hamano. I think it make sense to use generic term sides in this context, because the labels padding and margin are already visible in the UI.
t-hamano
changed the title
|
Thanks for the review! |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 22, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: mikachan <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: d685646 |
|
Thanks, @t-hamano! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…6304) Co-authored-by: t-hamano <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: mikachan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issue mentioned in this comment
What?
Uses a generic label for the linked button of the
SpacingSizesControlcomponent.Why?
The current implementation uses the label of the component itself as part of the text, which may not be appropriate for localization. Additionally, the placeholder text is forcibly changed to lower case via the
toLowerCase()method, which may not generate the proper text for some languages.How?
I use the label
Unlink sides,Link sides, which were also used before.Testing Instructions
Screenshots or screencast