Use npm workspaces for packages (second attempt) #66272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
changed the title
|
Size Change: +77 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Revert of the revert 😄 Let me know when to approve it again. |
sirreal
added
the
[Type] Project Management
|
There was a strange failure on CI while this was on trunk: https://github.com/WordPress/gutenberg/actions/runs/11435991643/job/31813748278 |
sirreal
force-pushed
the
revert-66270-revert-65681-managing-packages
branch
from
86e48fd to
b29b5cc
Compare
|
In the pull-request-automation workflow we hit this issue:
I think we should just use a single |
sirreal
force-pushed
the
revert-66270-revert-65681-managing-packages
branch
from
216ddb1 to
39b8690
Compare
|
There's an unrelated static analysis failure currently on trunk being fixed in #66316. You can see pull-request-automation passing on this branch here: https://github.com/WordPress/gutenberg/actions/runs/11459079724/job/31882816645?pr=66272 (this was a problem on trunk when this landed before). |
sirreal
requested review from
ObliviousHarmony,
t-hamano,
kevin940726,
ellatrix,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
luisherranz,
DAreRodz and
draganescu
as code owners
sirreal
requested review from
adamziel,
dmsnell,
atimmer,
mmtr,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
commented
Oct 22, 2024
Comment on lines
+34
to
+35
| }, | ||
| "wpScript": true |
There was a problem hiding this comment.
This was not in the original PR, this package was added in the interim in #64845.
|
Flaky tests detected in daf1d66. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11459264095
|
sirreal
force-pushed
the
revert-66270-revert-65681-managing-packages
branch
from
daf1d66 to
ab683b8
Compare
This reverts commit 5e3d247.
sirreal
force-pushed
the
revert-66270-revert-65681-managing-packages
branch
from
ab683b8 to
baa1899
Compare
sirreal
added a commit
that referenced
this pull request
Oct 25, 2024
Document recent changes to the build system that change are requirements for publishing WordPress scripts and script modules. #65064 updated the way that script modules from packages are bundled for Gutenberg and WordPress. #66272 updated the way that scripts from packages are bundled for Gutenberg and WordPress. --------- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: justintadlock <[email protected]> Co-authored-by: youknowriad <[email protected]>
|
Linking interesting follow-up conversation: #66428 (comment) |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Update package management to use npm workspaces instead of lerna. Lerna is obsolete for many repository management operations, such as dependency installation or script running. All of these are supported by npm now. Lerna continues to be used for publishing flows to ensure the appropriate dependencies are updated and published with the correct versions. The hope is that this simplfies dependendy management and maintains a more sane dependency tree. Dependency management has become increasingly difficult as Gutenberg has grown. --- This was originally merged in 4693c0f. It was reverted in order to merge it at a more time. --- Co-authored-by: t-hamano [email protected] Co-authored-by: sirreal [email protected] Co-authored-by: gziolo [email protected] Co-authored-by: ciampo [email protected] Co-authored-by: jsnajdr [email protected] Co-authored-by: yusuke-omae [email protected] Co-authored-by: kevin940726 [email protected]
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ress#66428) Document recent changes to the build system that change are requirements for publishing WordPress scripts and script modules. WordPress#65064 updated the way that script modules from packages are bundled for Gutenberg and WordPress. WordPress#66272 updated the way that scripts from packages are bundled for Gutenberg and WordPress. --------- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: justintadlock <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package management to use npm workspaces. Originally in #65681, reverted for timing reasons.
#66314 should have fixed an issue on CI observed while the original PR was merged to trunk.
From 4693c0f: