Icons: Add align-item related icons #66242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -12 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
It's a shame the text alignment icons weren't namespaced 😅 Do you think it would make sense to name these icons so that they're grouped with the other 'justify...' ones? IE:
|
|
Thanks for the review! I used the
So I used |
|
Yes that makes sense to me :) |
jameskoster
approved these changes
Oct 22, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Icons: Add align-item related icons * Use `justify` prefix Co-authored-by: t-hamano <[email protected]> Co-authored-by: jameskoster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds the following five icons:
alignItemBottomjustifyBottomalignItemCenterjustifyCenterVerticalalignItemSpaceBetweenjustifySpaceBetweenVerticalalignItemStretchjustifyStretchVerticalalignItemTopjustifyTopWhy?
Since we already have icons related to justify, I thought it would make sense to add icons related to align as well:
How?
There are already icons with the
alignprefix:The four icons other than
alignNoneshould ideally have thetextAlignprefix instead of the alignprefix, but this cannot be changed to ensure backward compatibility.Therefore, I used theI added thealignItemprefix for the newly added icons.justifyprefix to the newly added icon to group it with other justify-related icons. However, because there are name conflicts with the three iconscenter,spaceBetween, andstretch, I added the suffixvertical.Testing Instructions
npm run storybook:devScreenshots or screencast