Zoom Out: Disable zoom out toggle button when Style Book is open #66228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewserong
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +11 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Oct 18, 2024
Comment on lines
+40
to
+41
| accessibleWhenDisabled | ||
| disabled={ disabled } |
There was a problem hiding this comment.
TIL about this new prop.
Interesting that we don't just set accessibleWhenDisabled to true by default. I assume there's some logical reason why that's not the case.
There was a problem hiding this comment.
Yeah, I only learned about it thanks to the linter! As far as I can tell it's optional in Ariakit (https://ariakit.org/reference/button#accessiblewhendisabled), so I imagine our Button component has it optional either for consistency or back compat. I agree it feels a bit redundant, though, having to set it in a bunch of places as in Gutenberg I imagine we'd want to be using it all the time.
Good to keep in mind for future consolidation, for sure 👍
getdave
added
the
Backport to WP 6.7 Beta/RC
getdave
deleted the
try/disable-zoom-out-button-when-style-book-is-open
branch
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
getdave
pushed a commit
that referenced
this pull request
Oct 18, 2024
) Co-authored-by: andrewserong <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: colorful-tones <[email protected]> # Conflicts: # packages/editor/src/components/header/index.js
|
Manual backport here #66233. |
getdave
added a commit
that referenced
this pull request
Oct 19, 2024
) (#66233) Co-authored-by: andrewserong <[email protected]> Co-authored-by: madhusudhand <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: colorful-tones <[email protected]> # Conflicts: # packages/editor/src/components/header/index.js Co-authored-by: Andrew Serong <[email protected]> Co-authored-by: andrewserong <[email protected]> Co-authored-by: ajlende <[email protected]>
kevin940726
added
Backported to WP Core
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66127
Try disabling the Zoom Out Toggle button in the header when the Style Book is open
Why?
Clicking the button doesn't really do anything, so similar to what happens with the block inserter, try disabling the toggle button when the style book is open.
How?
Borrow the same approach as used for disabling block controls.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
2024-10-18.17.25.14.mp4