iAPI: Add tests for handling arrays in deepMerge()
#66218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalczaplinski
requested review from
desrosj,
ajitbohra,
gziolo,
ntwb,
nerrad,
ryanwelcher,
luisherranz,
DAreRodz,
tellthemachines and
ellatrix
as code owners
michalczaplinski
added
the
[Type] Code Quality
michalczaplinski
removed request for
desrosj,
gziolo,
ntwb,
ajitbohra,
ryanwelcher,
nerrad,
luisherranz,
ellatrix and
tellthemachines
michalczaplinski
force-pushed
the
tests/iapi-deep-merge
branch
from
49c5861
to
6f256bb
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
michalczaplinski
added
[Feature] Interactivity API
Base automatically changed from
fix/iapi-deep-merge-undefined-objects-reactivity
to
trunk
October 18, 2024 10:54
DAreRodz
force-pushed
the
tests/iapi-deep-merge
branch
from
05b0da9
to
c9361a1
Compare
|
Oops! Some wild merge conflicts appeared due to merging the base branch in advance. 🙈 I had to fix them by force-pushing the commits that only belonged to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I've added new unit tests for
deepMerge()to ensure it handles arrays correctly. I also grouped them under a commonarraysgroup.There is nothing else to test as this change only adds additional unit tests.