Tabs: restore vertical alignment for tabs content #66215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciampo
added
[Package] Components
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
requested changes
Oct 18, 2024
| @@ -234,6 +234,9 @@ export const Tab = styled( Ariakit.Tab )` | |||
|
|
|||
| export const TabChildren = styled.span` | |||
| flex-grow: 1; | |||
|
|
|||
| display: flex; | |||
| align-items: center; | |||
There was a problem hiding this comment.
It seems that tabs with icons that have custom wider widths will have icons that aren't centered:
Do we also need a justify-content: center:
Suggested change
| align-items: center; | |
| align-items: center; | |
| justify-content: center; |
ciampo
force-pushed
the
fix/tabs-vertical-centering
branch
from
b43b8d8 to
c780c0d
Compare
|
@tyxla feedback addressed:
|
|
Size Change: -56 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
changed the title
tyxla
approved these changes
Oct 18, 2024
| @@ -46,9 +46,3 @@ | |||
| .block-editor-block-inspector__no-block-tools { | |||
| border-top: $border-width solid $gray-300; | |||
| } | |||
|
|
|||
| .block-editor-block-inspector__tab-item { | |||
| @@ -9,21 +9,18 @@ export const TAB_SETTINGS = { | |||
| title: __( 'Settings' ), | |||
| value: 'settings', | |||
| icon: cog, | |||
| className: 'block-editor-block-inspector__tab-item', | |||
There was a problem hiding this comment.
Good riddance 👍
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ciampo <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR re-introduces some layout styles to
Tabs.Tabso that the tab contents are vertically centeredWhy?
Fixing an involuntary regression
How?
By re-adding flexbox styles to the Tab container
Testing Instructions
Note: the centering fix can't be seen when the tabs only contain text, as that's already working as expected.
Testing Instructions for Keyboard
Screenshots or screencast