Fix site editor back button visual regressions #66166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Regression
jameskoster
requested review from
a team,
ockham and
jorgefilipecosta
and removed request for
a team
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Looking at the after screenshot I notice the site title / icon are not aligned with the back button / sidebar title. We should probably shift the button + title over. However the site icon is only 
Happy to work on that here or in a follow-up, what do y'all think? |
|
Size Change: +26 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
LGTM 👍 Thanks for the fix @jameskoster 🚀
Happy to work on that here or in a follow-up, what do y'all think?
A follow-up makes sense to me 👍
tyxla
reviewed
Oct 16, 2024
ciampo
reviewed
Oct 16, 2024
| @@ -14,7 +14,7 @@ | |||
| outline: 3px solid transparent; | |||
| } | |||
|
|
|||
| &:hover, | |||
| &:hover:not(:disabled,[aria-disabled=true]), | |||
| &:focus-visible, | |||
| &:focus, | |||
| &:not([aria-disabled="true"]):active, | |||
There was a problem hiding this comment.
Should we add :disabled here too, to align with the selector introduced above?
There was a problem hiding this comment.
Also, looking forward to color theming which will hopefully make such overrides unneded
Co-authored-by: Marin Atanasov <[email protected]>
|
Thanks for this PR! I just realized I recorded a featurette where this issue is visible, and now I can't unsee it 🙈 |
|
Flaky tests detected in 612797c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11363862046
|
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 16, 2024
Co-authored-by: jameskoster <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]> Co-authored-by: jasmussen <[email protected]>
github-actions
bot
added
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: b43d31f |
|
I'm seeing a build error for this on
|
|
It seems the |
|
@jameskoster can you confirm whether this is supposed to be a part of |
|
I would plead to this being in 6.7, it's an important visual artifact regression. |
|
We could backport #65418 so the variable is available. Failing that I suppose we'll need a new PR replacing the variable with a hardcoded value 😓 |
|
Could we submit a new PR to the Backporting #65418 would also solve the problem, but I'm a bit hesitant because so many scss variables have changed. |
|
Yes, I won't be able to get to it until tomorrow though. |
I looked through all the modified lines to make sure that all the previously available variables are unchanged. We can safely backport #65418 if we're okay with the new variables being part of core. EDIT: I opened #66184 so we don't have to worry about the added variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Somewhere in the 6.7 dev cycle a couple of visual regressions were introduced to the back button in the site editor sidebar:
40pxsizing, which breaks alignment with the titleThis PR addresses both issues.
Why?
Visual polish.
How?
compact(32px) size variantline-heighton the sidebar title tofont-line-height-x-large(32px) to ensure alignmentTesting Instructions
Before
After