Navigation block: fix block appender size #66153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +15 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
aaronrobertshaw
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Thanks for the attention to detail here @t-hamano 🕵️
In terms of this being a quick fix for 6.7, it works for me. The issue referenced in the linked code comment has been closed so it might be good to spin up a fresh issue for a longer term fix, so it won't fall through the cracks.
| Before | After |
|---|---|
  |
  |
|
Thanks for the review!
Submitted 👍 |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 17, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 97e96d7 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR changes the height of the navigation block inserter so that it is an exact square.
Why?
As part of an effort to standardize buttons to a default 40px size, #65225 added
__next40pxDefaultSizeto the block appender. Normal block appenders are correct to be 40px in size, but the Navigation block is expected to be 24px as before.How?
Override the default 40px height with a 24px height. This is a temporary fix for WP 6.7, we may need to update to the dropdown appender in the feature as this comment indicates.
Testing Instructions
Select the Navigation block and Submenu block and check the size of the block appenders.
Screenshots or screencast
Before
After