Scripts: Add BlueOak-1.0.0 license to GPL2 compatible #66139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirreal
added
[Type] Enhancement
sirreal
requested review from
gziolo,
ntwb,
nerrad,
ajitbohra and
ryanwelcher
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Blueoak is not currently listed on https://www.gnu.org/licenses/license-list.en.html as being GPL compatible but I don't see any specific problems. Still might be good to get a lawyer to sign off on it. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
|
I checked with the Automattic legal team and the license should be compatible:
I also reached out to |
|
We can update now the command that runs when checking the license. From: Line 311 in f99eb38 To: |
gziolo
approved these changes
Oct 17, 2024
This license appears on some npm packages. It intended to be highly permissive. The website states that it should be GPLv2 compatible: > Is the model license compatible with GPL? > The Council doesn’t see any reason why software licensed under the > Blue Oak Model License 1.0.0 can’t be used, combined, and distributed > with software under GPLv2, LGPLv2.1, GPLv3, LGPLv3, or AGPLv3. https://blueoakcouncil.org/license-faq
sirreal
force-pushed
the
add/scripts--check-licenses--blueoak1.0.0
branch
from
796a7e3 to
ff17328
Compare
|
Flaky tests detected in ff17328. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11383365239
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
- Add BlueOak-1.0.0 to GPLv2 compatible licenses recognized by wp-scripts check-licenses. - Remove redundant ignores from Gutenberg's check-licenses script. This license appears on some npm packages. It's intended to be highly permissive. The website states that it should be GPLv2 compatible: > Is the model license compatible with GPL? > > The Council doesn’t see any reason why software licensed under the > Blue Oak Model License 1.0.0 can’t be used, combined, and distributed > with software under GPLv2, LGPLv2.1, GPLv3, LGPLv3, or AGPLv3. https://blueoakcouncil.org/license-faq --- Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: aaronjorbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add BlueOak-1.0.0 to GPLv2 compatible licenses recognized by wp-scripts check-licenses.
This license appears on some npm packages. It intended to be highly
permissive. The website states that it should be GPLv2 compatible:
https://blueoakcouncil.org/license-faq
Why?
The license appears in Gutenberg's dependencies and seems to be compatible. Add it.
Testing Instructions
Run this on trunk and this branch:
Trunk shows errors errors with the license:
This branch does not.