Update and align babel dependencies version #65949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
ciampo
force-pushed
the
update/babel-7-25-7
branch
2 times, most recently
from
44efca7 to
2ea5744
Compare
ciampo
requested review from
ellatrix,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
draganescu,
adamziel,
kevin940726,
dmsnell,
atimmer and
mmtr
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in 5a61b80. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11243188325
|
gziolo
reviewed
Oct 9, 2024
package.json
Outdated
| "@babel/core": "7.25.7", | ||
| "@babel/plugin-syntax-jsx": "7.25.7", | ||
| "@babel/plugin-transform-async-generator-functions": "7.25.7", | ||
| "@babel/plugin-transform-export-namespace-from": "7.25.7", |
There was a problem hiding this comment.
Do you know why the name of the package has changed? Maybe it is natively supported now and it could be dropped now?
There was a problem hiding this comment.
Both of these plugins (async-generator-functions and export-namespace-from) are part of the default preset (@babel/preset-env) we're using, so we should be able to remove them as explicit dependencies.
There was a problem hiding this comment.
The @babel/plugin-proposal-export-namespace-from and @babel/plugin-proposal-async-generator-function are deprecated, and their docs reference the new packages that replaces them:
- https://www.npmjs.com/package/@babel/plugin-proposal-export-namespace-from
- https://www.npmjs.com/package/@babel/plugin-proposal-async-generator-functions
Both of these plugins (
async-generator-functionsandexport-namespace-from) are part of the default preset (@babel/preset-env) we're using, so we should be able to remove them as explicit dependencies.
@tyxla just to make sure I understand, are you suggesting the removal of @babel/plugin-transform-async-generator-functions and @babel/plugin-transform-export-namespace-from?
Should we add an explicit dependency from @babel/preset-env, then ?
There was a problem hiding this comment.
I thought this might be related to deprecated warnings when running npm ci like this:
npm warn deprecated @babel/[email protected]: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-nullish-coalescing-operator instead.
But I still see them on this branch. Not a blocker but it would be great to track those all down.
There was a problem hiding this comment.
Many babel plugins are referenced directly in the native test config:
gutenberg/test/native/babel.config.js
Lines 6 to 16 in 6be7f8f
There was a problem hiding this comment.
@tyxla just to make sure I understand, are you suggesting the removal of @babel/plugin-transform-async-generator-functions and @babel/plugin-transform-export-namespace-from?
Ideally, yes, unless there's a good reason to keep them.
Should we add an explicit dependency from @babel/preset-env, then ?
There should already be one in the @wordpress/babel-preset-default project. Worth verifying if all different type of tests use that preset though.
Not a blocker but it would be great to track those all down.
I agree this isn't a blocker and can be done separately 👍
Would be nice to check if we can ditch them for the react native tests and wherever else we're specifically referencing them.
There was a problem hiding this comment.
Yes, it's definitely a follow-up. I mostly wanted to raise it as I had some blurry memories that they standardized the naming to make it easier to distinguish that the proposal becomes the standard, so moving forward, it should be part of the @babel/preset-env. The Babel config for React Native might have some differences, so that needs to be double checked if it is still required there.
There was a problem hiding this comment.
I removed the @babel/plugin-transform-async-generator-functions and @babel/plugin-transform-export-namespace-from dependencies from package.json, the package-lock.json still includes them:
So, if all CI checks pass, I guess we're probably better off omitting them anyway, as they should be already included with the dependencies of @wordpress/babel-preset-default (search for "packages/babel-preset-default/node_modules/@babel/preset-env" in the package-lock.json file).
If folks are ok with the current state of the PR, I'd like to stop here and get it merged to limit the scope.
There was a problem hiding this comment.
Sounds good to me. Doing some final testing now.
gziolo
reviewed
Oct 9, 2024
| "@babel/preset-env": "^7.16.0", | ||
| "@babel/preset-typescript": "^7.16.0", | ||
| "@babel/runtime": "^7.16.0", | ||
| "@babel/core": "7.25.7", |
There was a problem hiding this comment.
Let's add the changelog entry for this package so it's clear that these dependencies were updated.
There was a problem hiding this comment.
Done in 4c83b1c (#65949)
gziolo
reviewed
Oct 9, 2024
tyxla
reviewed
Oct 9, 2024
package-lock.json
Outdated
| "peerDependencies": { | ||
| "@babel/core": "^7.0.0-0" | ||
| } | ||
| }, | ||
| "node_modules/@babel/plugin-proposal-nullish-coalescing-operator": { |
There was a problem hiding this comment.
Kind of a bummer that some of the modules are still using the old proposal versions when there are respective transform plugin alternatives (https://babeljs.io/docs/babel-plugin-transform-nullish-coalescing-operator).
Not much we can do here, this one seems to be a dependency of a few React Native related packages.
package.json
Outdated
| "@babel/core": "7.25.7", | ||
| "@babel/plugin-syntax-jsx": "7.25.7", | ||
| "@babel/plugin-transform-async-generator-functions": "7.25.7", | ||
| "@babel/plugin-transform-export-namespace-from": "7.25.7", |
There was a problem hiding this comment.
Both of these plugins (async-generator-functions and export-namespace-from) are part of the default preset (@babel/preset-env) we're using, so we should be able to remove them as explicit dependencies.
…l/plugin-transform-export-namespace-from` as they are included with other dependencies
ciampo
force-pushed
the
update/babel-7-25-7
branch
from
5a61b80 to
4c83b1c
Compare
tyxla
approved these changes
Oct 9, 2024
|
I didn't notice that before. All dependencies for Babel packages are listed as specific versions instead of using ranges. Was there any reason behind it, or was it overlooked? |
|
The reason was to avoid misalignment between versions across the package. Previously we had a mix of required versions, both ranges and specific versions, which led to multiple versions being installed. Having said that, feel free to change it to whatever strategy you think it's best, I definitely don't have much experience on this aspect of the project. |
|
We might hear back from folks once they run into issues when they start trying to upgrade packages. Historically, the biggest issue we encountered with the WP release process was when one of the dependencies was pinned so I’m a bit worried about consequences… |
|
I understand — feel free to change from |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Update @babel/* dependencies to 7.25.7 * Swap old proposal-* plugin to transform-* plugins * Update non-official, babel-* dependencies * Update package-lock.json * Remove `@babel/plugin-transform-async-generator-functions` and `@babel/plugin-transform-export-namespace-from` as they are included with other dependencies * Update platform docs package-lock.json * CHANGELOG -- Co-authored-by: ciampo <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: sirreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update and align babel-related dependencies
Why?
As flagged in #65913 (comment), currently babel-related dependencies use different versions.
This PR aligns all babel-related dependencies to use the latest stable available version.
It also swaps a couple of deprecated babel plugins for the respective stable version.
How?
package.jsonfiles manuallypackage-lock.jsonTesting Instructions