Editor: Introduce editor.init action hook for extensibility
#65921
+220
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Technical Prototype
|
Size Change: +13 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
This would be very useful! ❤️ |
|
I like where this is going. That said, I do wonder what's best: Do we want a generic I guess the question comes down to: do we see all the "editor extensibility" APIs as something that live only the editor or do we see ourselves for instance registering blocks elsewhere and in which case dedicated actions is better. Maybe an audit of all the things that we "register" is needed. The other question I have is: Should we use an asynchronous action (introduced recently by @jsnajdr ) or a synchronous one. |
In my view this should be a synchronous action. We don't want to encourage people to delay the editor initialization by fetching something over network or doing other async work. If you need this, it's a signal that it belongs somewhere else. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Triggered by the conversation started by @colorful-tones in #65713 (comment)
Raised also previously by me in #64138 (comment):
Why?
It isn't different from past issues that people had with unregistering block types like #9757 or #9757. Same 3rd party blocks get registered with
wp.blocks.registerBlockTypebefore other plugins register their filters that modify blocks during block registration. That was mitigated with #34299 that reapplies the most recent filters to previously registered blocks.However, there are more examples where we could offer better alternatives other than using
wp.domReadyto defer executing the code or programmatically move the place where the custom script is printed by making it dependent, for example, on thewp-edit-postscript handle. The root issue is that there isn't a formal way to let 3rd party code run code in a predictable order. On the server, there are WP actions likeinitoradmin_initthat offer a chance to run the code after or before core, plugin and themes run their logic.How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast