Block Visibility: Add e2e test #65880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.77 MB ℹ️ View Unchanged
|
Mamaduka
reviewed
Oct 4, 2024
Mamaduka
reviewed
Oct 4, 2024
|
I really appreciate the follow-up @t-hamano I should have done so myself :P |
youknowriad
approved these changes
Oct 4, 2024
|
Flaky tests detected in 2fe53a6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11189198871
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Block Visibility: Add e2e test * Use `toHaveCount` instead of `toBe` Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of this comment: #62703 (comment)
What?
Add e2e test for the "Manage block visibility" setting
Why?
I think we need to make the
BlockManagercomponent reusable to implement UI for allowedBlocks, but before that, we need E2E tests to prevent unintended regressions.How
I have tested the basic functionality, but if there is anything else I should test, please let me know.
Testing Instructions
Run one of the following codes: