Focus first section root block if no selected block and tabbing to zoom out canvas #65843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
jeryj
commented
Oct 2, 2024
| const { setLastFocus } = unlock( useDispatch( blockEditorStore ) ); | ||
| const { getLastFocus } = unlock( useSelect( blockEditorStore ) ); |
There was a problem hiding this comment.
Moved this up to the other useSelect, as there shouldn't be a reason to use them in separate places.
jeryj
added
[Type] Bug
|
Size Change: -54 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jeryj
changed the title
MaggieCabrera
approved these changes
Oct 3, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65830
Why?
No visible or useful focus when tabbing to the canvas in zoom out mode without a block selection.
How?
On tab nav focus capture, if in zoom out, focus the first block of the section root. This will also cause it to be selected. If there are no section blocks, focus the section root wrapper instead.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Recording.2024-10-03.at.11.02.02.AM.mov