-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query Loop: Use templateSlug and postType for more context #65820
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +122 B (+0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
Flaky tests detected in 08a3ad4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11142291059
|
What?
The Query Loop block currently does not have much context about where it has been added when viewed in the Editor, and in some cases, it does not always make sense to inherit the global query. In #65067, we discussed that these cases can mostly be split between whether the block has been added to singular content, such as a single post or page; or non-singular content, such as the archive template or category template.
We addressed some of this logic in #65067, however, this only covered cases where the block is added to single posts or pages. As a follow-up to #65067, this PR also considers the 404, blank, and custom templates as singular content while also refactoring this recently added logic.
This PR does not add any other context for when the block is added to non-singular content, but I think we should address these cases in follow-up PRs, including:
Why?
Part of #30369, and a follow-up to #65067.
How?
templateSlug
to the context available to the Query Loop block, which allows us to check which template is in use before deciding whether to inherit the query. There is some prior art in Decouple query from edit site #27972.postType
, if available, to the current query.Testing Instructions
The functionality isn't too different to trunk, other than the 404, blank and custom templates are now included in the list of "singular content" contexts (i.e.
isSingular
). ThepostType
is also being applied where it's available, so please also test templates and content for custom post types.inherit: false
in singular content.inherit: true
in non-singular content.Screenshots or screencast