Try zooming out when selecting the patterns tab in the inserter #65785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Just wondering whether we want to keep zoomed out engaged when moving to the |
getdave
reviewed
Oct 1, 2024
There was a problem hiding this comment.
This approach works well technically as far as I can see.
More only thought was do we want to disengage when selecting Media as well? Because it is potentially useful to be able to drag and drop media into Patterns in the canvas when Zoomed Out.
I'll defer to @richtabor for final ✅ from a design perspective.
Yes, Media tab should not engage or disengage zoom out. |
jeryj
reviewed
Oct 1, 2024
draganescu
force-pushed
the
try/zoom-out-view-in-patterns-tab
branch
from
de40c63 to
07e3c91
Compare
|
@getdave for me it works like the video I posted in the description, so it appears the media tab works as expected (save for that blank panel which appears to be a separate bug). |
getdave
approved these changes
Oct 2, 2024
getdave
force-pushed
the
try/zoom-out-view-in-patterns-tab
branch
from
07e3c91 to
75a3112
Compare
|
Hopefully rebase allows this to pass tests 🤞 |
draganescu
force-pushed
the
try/zoom-out-view-in-patterns-tab
branch
2 times, most recently
from
694f717 to
4f9fbac
Compare
|
I think leaving zoom out engaged when closing the inserter (if set via the pattern tab click) is the incorrect UX. I think zoom out should automatically disengage if the inserter is closed and it was programmatically set by us:
Screen.Recording.2024-10-04.at.11.05.17.AM.movcc @richtabor |
I agree. #65749 (comment) |
|
So the patterns tab of the inserter becomes another toggle for zoom out juts like the one in the header, but it's not the tab itself it's the whole inserter if I close it, or if I swith to the blocks tab, but not to the media tab, and also I can just click the icon in the header. I find this quite confusing and a tell tale that we're not clear on what zooming is for. We also have a behavior (also found by @jeryj here) that automatically sets the patterns tab active when the inserter is open and zoom out is active. Tha behaviour tripped me as a user - I thought the selected tab is magically restored 🤷🏻 . |
draganescu
force-pushed
the
try/zoom-out-view-in-patterns-tab
branch
from
4f9fbac to
959e07a
Compare
|
I have updated this to use the hook we have as advised by @jeryj and now it works in all ways, will merge as soon as tests pass:
There is but one left awkwatd interaction where, with zoom out off, the user toggles patterns zoom out is engaged, the user toggles off zoom out, goes to blocks, goes back the patterns, zoom out is again engaged. Seems kinda annoting - but also I suspect a very rare flow. Replaced the video description of PR with a demo of the above. |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 7, 2024
* adds handler for inserter tabs that engages zoom out view and mode * Only moving to blocks should reset zoom out mode * use hook to handle zoom out view, the hook respects the current zoom out setting --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: richtabor <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: ed3e4d3 |
2 tasks
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…Press#65785) * adds handler for inserter tabs that engages zoom out view and mode * Only moving to blocks should reset zoom out mode * use hook to handle zoom out view, the hook respects the current zoom out setting --------- Co-authored-by: draganescu <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: richtabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #65749
Why?
Now that the zoom out view is easy to exit, automagically engaging it when patterns are about to be inserted seems a better idea. We have had this before, disabled it and now we're bringing it back.
How?
In the Inserter's menu we add a handler that deals with zoom out depending on what tab is selected.
Testing Instructions
or media tabstab (only) exits the zoom out view and modePatternswill active Zoom Out. Media does nothing.Testing Instructions for Keyboard
N/A
Screenshots or screencast
inserter-zoom-out-dance.mp4
Co-authored-by: draganescu [email protected]
Co-authored-by: getdave [email protected]
Co-authored-by: richtabor [email protected]
Co-authored-by: jeryj [email protected]