Social Links: Fix block appender size #65769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
Note: This issue does not occur in WP 6.7 so no backport is needed. |
t-hamano
force-pushed
the
fix/social-icons-inserter
branch
from
a226c94
to
ad71627
Compare
t-hamano
commented
Oct 1, 2024
Comment on lines
-110
to
+104
| &.has-small-icon-size .block-editor-button-block-appender.components-button.components-button { | ||
| .block-editor-button-block-appender { |
There was a problem hiding this comment.
From what I've tested, it doesn't seem like we need to increase the CSS specificity too much.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -126 B (-0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jeryj
approved these changes
Oct 1, 2024
jeryj
force-pushed
the
fix/social-icons-inserter
branch
from
ad71627
to
54bdaad
Compare
|
Rebased and force pushed. There was a failing playwright test that I also had on one of my PRs, and it wouldn't pass until I rebased :) |
|
Thanks for the review! |
|
Thanks for this PR 👍👍 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: jeryj <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit 3829579.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: jeryj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65766
Related to #64877
What?
This PR fixes two issues with the social link block:
Why?
#65225 applied a new 40px default size to inserter buttons. This makes the component's CSS specificity higher and overrides
height:auto:How?
Instead of relying on padding to determine the size of the button, I give the inserter button an explicit width and height in em units. This ensures that the inserter will always be the same size as the icon, even if a custom size is needed in the future:
b8dfd482fc5c1153db2a2809184fcfb6.mp4
Testing Instructions