Buttons: add box-sizing:border-box rule #65716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
Size Change: +40 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aaronrobertshaw
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Thanks for cleaning this up @t-hamano ✨
I think this rule is necessary for wp-block--based blocks that support padding.
Any block that has border support also really needs the box-sizing: border-box style.
I consider adding box-sizing an enhancement rather than a bug fix, but I am wondering whether this should be backported to WP 6.7.
I would view this more as a bug fix given the parent's width that should be being enforced hasn't been until now.
I don't hold strong opinions on whether this should be backported or not. Even if it is viewed as a bug fix, it's for a niche edge case and the bug isn't severe. I'd be fine with this landing in GB without backporting but happy if others feel differently.
You could always double check with the release leads.
This is testing as advertised for me.
| Editor - Before | Editor - After |
|---|---|
 |
 |
| Frontend - Before | Frontend - After |
|---|---|
 |
 |
|
@aaronrobertshaw Thanks for the review! I too believe this is an edge case, so I don't have a strong opinion on whether it should be backported to WP 6.7 or not. |
getdave
pushed a commit
that referenced
this pull request
Oct 1, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit 24d0930.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #63538
What?
This PR applies
box-sizing: border-boxto the Buttons block, so that its size when padding and background color are applied will match that of other blocks.Why?
As mentioned in #43465, I think this rule is necessary for
wp-block--based blocks that support padding.However, some users may prefer to fit the buttons inside to the container width instead of the wrapper block. Please let me know your thoughts.
Testing Instructions
Insert a Buttons block and apply padding, border and background color to it.
Screenshots or screencast
Below are screenshots of Twenty Twenty-Five:
Note
I consider adding
box-sizingan enhancement rather than a bug fix, but I am wondering whether this should be backported to WP 6.7.By the way, Twenty Twenty-Five should not be affected by this change (Search results by
"<!-- wp:buttons").