Button: Add __next40pxDefaultSize in dataviews, reusable-blocks, etc.
#65715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
commented
Sep 28, 2024
| label={ __( 'Close' ) } | ||
| icon={ closeSmall } | ||
| onClick={ onClose } | ||
| size="small" |
There was a problem hiding this comment.
Enable the "Quick Edit in DataViews" experiment. Go to the list of Pages in Site Editor and enable the Table view. Toggle the details panel to the right, and click on a field to show the edit popover.
No visual changes:
| @@ -44,16 +44,3 @@ | |||
| .dataforms-layouts-panel__dropdown-header { | |||
| margin-bottom: $grid-unit-20; | |||
| } | |||
|
|
|||
| [class].dataforms-layouts-panel__dropdown-header-action { | |||
There was a problem hiding this comment.
Removing this CSS because nothing else is using this class.
Comment on lines
+20
to
+21
| size="compact" | ||
| className="list-reusable-blocks-import-dropdown__button" |
There was a problem hiding this comment.
Go to http://localhost:8888/wp-admin/edit.php?post_type=wp_block.
| Before | After |
|---|---|
 |
 |
Comment on lines
-9
to
-12
| // Todo: Make core button height and gutenberg button height equal. | ||
| .components-button { | ||
| height: 26px; | ||
| } |
There was a problem hiding this comment.
Moved to a custom class name in packages/list-reusable-blocks/src/components/import-dropdown/style.scss.
| @@ -1,3 +1,8 @@ | |||
| .list-reusable-blocks-import-dropdown__content .components-popover__content { | |||
| padding: 10px; | |||
| } | |||
|
|
|||
| [class].list-reusable-blocks-import-dropdown__button { | |||
There was a problem hiding this comment.
[class] selector added for more specificity.
There was a problem hiding this comment.
It's a bummer this is necessary, but it makes sense since the other button is outside our control.
| @@ -84,8 +84,7 @@ function ImportForm( { instanceId, onUpload } ) { | |||
| </label> | |||
| <input id={ inputId } type="file" onChange={ onChangeFile } /> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Go to http://localhost:8888/wp-admin/edit.php?post_type=wp_block and click the Import from JSON button to show the popover.
| Before | After |
|---|---|
 |
 |
There was a problem hiding this comment.
Actually, does it make sense to use a compact button here?
I think the large 40px size feels odd with the rest of the buttons around:
And here's how it would look with a size="compact":
It's still 32px (vs 30px for the 2 other buttons), but 32px is much closer to 30px than 40px.
Thoughts?
There was a problem hiding this comment.
Mmm, it's a tough call! I agree the compact size looks much more harmonious in the current state, but also I believe the wp-admin pages are going to slowly migrate to the React componentry eventually. In that case, we will be adding tech debt by setting an explicit "compact" here, as that doesn't adhere to the design system guidelines. I think I slightly prefer the path of least resistance (i.e. default size), since everything is kinda wonky anyway? 😅
There was a problem hiding this comment.
You have a point about adding tech debt if we pick a different size.
I wish we could fix both the top buttons right here and right now, but it's a bigger can of worms.
| @@ -5,7 +5,6 @@ | |||
|
|
|||
| .list-reusable-blocks-import-form__button { | |||
| margin-top: 10px; | |||
| margin-bottom: 10px; | |||
There was a problem hiding this comment.
Removed unnecessary margin bottom.
| @@ -57,17 +57,15 @@ export function DotTip( { | |||
| <p>{ children }</p> | |||
| <p> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
The nux package is not used anymore and has long been deprecated so we can't see an actual render, but here is an old screenshot:
The link variant should remain the same height, and the "Disable tips" button is the close button in the top right.
| @@ -191,8 +191,7 @@ export default function ReusableBlockConvertButton( { | |||
| /> | |||
| <HStack justify="right"> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
This isn't used in the app anymore, but we can infer that it's safe from the similar UI patterns like this:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
21 tasks
|
Size Change: +640 B (+0.04%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Sep 30, 2024
| @@ -1,3 +1,8 @@ | |||
| .list-reusable-blocks-import-dropdown__content .components-popover__content { | |||
| padding: 10px; | |||
| } | |||
|
|
|||
| [class].list-reusable-blocks-import-dropdown__button { | |||
There was a problem hiding this comment.
It's a bummer this is necessary, but it makes sense since the other button is outside our control.
| @@ -84,8 +84,7 @@ function ImportForm( { instanceId, onUpload } ) { | |||
| </label> | |||
| <input id={ inputId } type="file" onChange={ onChangeFile } /> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
Actually, does it make sense to use a compact button here?
I think the large 40px size feels odd with the rest of the buttons around:
And here's how it would look with a size="compact":
It's still 32px (vs 30px for the 2 other buttons), but 32px is much closer to 30px than 40px.
Thoughts?
tyxla
reviewed
Sep 30, 2024
| variant="link" | ||
| onClick={ onDismiss } | ||
| > | ||
| { hasNextTip ? __( 'See next tip' ) : __( 'Got it' ) } | ||
| </Button> | ||
| </p> | ||
| <Button | ||
| // TODO: Switch to `true` (40px size) if possible | ||
| __next40pxDefaultSize={ false } | ||
| size="small" |
There was a problem hiding this comment.
We'll also need to update the test snapshots here.
mirka
added
the
Backport to WP 6.7 Beta/RC
noisysocks
added
Backported to WP Core
noisysocks
pushed a commit
that referenced
this pull request
Oct 1, 2024
…c. (#65715) * Fix in Dataforms layouts * Fix in Patterns header * Fix in Patterns import popover * Fix in nux * Fix in ReusableBlockConvertButton * Update snapshot Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…c. (WordPress#65715) * Fix in Dataforms layouts * Fix in Patterns header * Fix in Patterns import popover * Fix in nux * Fix in ReusableBlockConvertButton * Update snapshot Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
…ocks, etc. (WordPress#65715)" This reverts commit 419a418.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65018
What?
Adds the
__next40pxDefaultSizeprop to Buttons in the following packages:dataviewslist-reusable-blocksnuxreusable-blocks