-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BorderControl: Use __next40pxDefaultSize
prop for Reset button
#65682
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cabdda2
to
029cbb5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk.
|
⬆️ This usually happens when a dependant PR was not cherry-picked . I managed to solve a similar issue by cherry picking the dependendant PR, and then removing+re-adding the cherry-pick label to the current PR |
@ciampo Thanks for the hint. Aaandd ugh it's a changelog conflict. |
Yeah, improving the CHANGELOG is another thing that is never high priority enough but keeps being annoying |
If I understand correctly, this has been backported already, right? |
No, I rescinded it from backport because the changelog stuff was too annoying and the formal size deprecation was punted to 6.8 😅 |
Ah, got it. Thanks for confirming @mirka 🙇♂️ |
What?
This PR updates the "Reset" button of the
BorderControl
component to use the new 40px default size.Why?
Discovered as I was auditing button sizes as part of reviewing #65018.
How?
We're adding the
__next40pxDefaultSize
prop to the "Reset" button. The button was already set to40px
through CSS, but we no longer need that style override when we can just opt in with the__next40pxDefaultSize
prop.Testing Instructions
/?path=/story/components-experimental-bordercontrol--default
Testing Instructions for Keyboard
Same
Screenshots or screencast