Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide: Update finish button to use the new default size #65680

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Sep 26, 2024

What?

This PR updates the "Finish" button of the Guide component to use the new 40px default size.

Why?

Discovered as I was auditing button sizes as part of reviewing #65018.

How?

We're adding the __next40pxDefaultSize prop to the "Finish" button. The rest of the buttons already used that size, so we're just making all buttons consistent now.

Testing Instructions

  • Open Storybook: /?path=/docs/components-guide--docs
  • Open the guide.
  • Go to the last step.
  • Verify the "Finish" button is the same size as the "Previous" button (40px).

Testing Instructions for Keyboard

Same

Screenshots or screencast

Before After
Screenshot 2024-09-26 at 17 35 48 Screenshot 2024-09-26 at 17 35 26

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Sep 26, 2024
@tyxla tyxla requested a review from a team September 26, 2024 14:37
@tyxla tyxla self-assigned this Sep 26, 2024
@tyxla tyxla requested a review from ajitbohra as a code owner September 26, 2024 14:37
Copy link

github-actions bot commented Sep 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <[email protected]>
Co-authored-by: ciampo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tyxla tyxla merged commit b1f07db into trunk Sep 26, 2024
61 of 62 checks passed
@tyxla tyxla deleted the fix/guide-finish-button-size branch September 26, 2024 15:17
@github-actions github-actions bot added this to the Gutenberg 19.4 milestone Sep 26, 2024
Copy link

There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch.

PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk.

# Checkout the wp/6.7 branch instead of trunk.
git checkout wp/6.7
# Create a new branch for your PR.
git checkout -b my-branch
# Cherry-pick the commit.
git cherry-pick b1f07db58b9b9dcf5068a7e88e63dbf845cef91b
# Check which files have conflicts.
git status
# Resolve the conflict...
# Add the resolved files to the staging area.
git status
git add .
git cherry-pick --continue
# Push the branch to the repository
git push origin my-branch
# Create a PR and set the base to the wp/6.7 branch.
# See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request.

noisysocks pushed a commit that referenced this pull request Sep 30, 2024
* Guide: Update finish button to use the new default size

* CHANGELOG

Co-authored-by: tyxla <[email protected]>
Co-authored-by: ciampo <[email protected]>
@noisysocks noisysocks added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta labels Sep 30, 2024
@tyxla
Copy link
Member Author

tyxla commented Oct 7, 2024

@noisysocks if I understand correctly, this has already been backported, but let me know if I can help with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants