-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide: Update finish button to use the new default size #65680
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk.
|
* Guide: Update finish button to use the new default size * CHANGELOG Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
@noisysocks if I understand correctly, this has already been backported, but let me know if I can help with anything. |
What?
This PR updates the "Finish" button of the Guide component to use the new 40px default size.
Why?
Discovered as I was auditing button sizes as part of reviewing #65018.
How?
We're adding the
__next40pxDefaultSize
prop to the "Finish" button. The rest of the buttons already used that size, so we're just making all buttons consistent now.Testing Instructions
/?path=/docs/components-guide--docs
Testing Instructions for Keyboard
Same
Screenshots or screencast