Embed block: replace twitter icon with x icon #65580
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Changes the Twitter icon in the
twitter
variation of the Embed block to the X icon.Why?
The
twitter
variation in the embed block was still using the Twitter icon.How?
This changes the
title
,description
, andicon
attributes of the Twitter variation.As the title attribute is no longer
Twitter
, two new keywords were also added (x
andtwitter
) so thetwitter
variation remains easily searchable.The actual variation name remains
twitter
, since changing this would cause issues for existing Twitter/X embeds.Testing Instructions
Screenshots or screencast
Related: #55142