-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts: Update sass
and sass-loader
packages
#65563
Conversation
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was fixed with #67572. Tested with @wordpress/[email protected]. The stable version is expected to be published to npm on Wednesday. Do you plan to continue working on this PR? |
@gziolo I'm overloaded right now, so I don't plan to continue working on this anytime soon. Do you want me to close the related WP PRs that I am no longer actively working on? |
That's fair. Thank you for helping with these efforts 🙇🏻♂️ I'll close this PR. Let me quickly check your other PRs to see whether we can move forward something 😄 |
What?
Updates the
sass
andsass-loader
dependencies used in@wordpress/scripts
.Why?
The older version of
sass-loader
is using a legacy API that is coming to end-of-life. See https://sass-lang.com/documentation/breaking-changes/legacy-js-api/.The
@wordpress/scripts
build process also shows multiple warnings every time it runs when sass files exist. This update removes them.How?
This updates the
@wordpress/scripts package.json
file as well as themain package.json
andmain package-lock.json
files to use the most recent updated version of sass and sass-loader.Testing Instructions
@wordpress/scripts
:npm install
npm run build