-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom out: hide toolbar icon on smaller viewports #65437
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢 it
@@ -143,7 +143,7 @@ function Header( { | |||
/> | |||
<PostViewLink /> | |||
|
|||
<ZoomOutToggle /> | |||
{ isWideViewport && <ZoomOutToggle /> } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late review.
Isn't this isLargeViewport
? Otherwise, it won't match the visibility of the device preview button.
The device preview dropdown appears when the browser width is 783px
or more, while the zoom out toggle appears when the browser width is 960px
or more:
b4a7f927436d6bfae2905801eea44165.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not so sure zoom out and device preview need to behave exactly the same. I would worry more about: is the viewport large enough for zoom out to be a good experience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the zoom out mode requires a wide viewport to work properly, shouldn't that be the case in device preview as well? Either way, I would expect device preview and zoom out mode to follow consistent viewport rules.
What?
Closes #65431
Why?
Zoom out doesn't make sense on mobile, so we might as well hide it
How?
Checks for the viewport width to conditionally render the zoom out button on the toolbar
Testing Instructions
Check that the icon is not showing when on smaller viewports
Testing Instructions for Keyboard
Screenshots or screencast