Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add soft deperecation notice for the ButtonGroup component #65429

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

hbhalodia
Copy link
Contributor

What?

Issue - #65338

Why?

How?

  • PR add the @deprecate on JS Doc.
  • PR updates the README and story book to feature as deprecated.

Testing Instructions

  1. Use ButtonGroup component, it should show the warning in console with deprecation message.

Testing Instructions for Keyboard

  • NIL

Screenshots or screencast

Screenshot 2024-09-18 at 10 35 19 AM

Copy link

github-actions bot commented Sep 18, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
  • Labels found: [Status] Blocked.

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Sep 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: ciampo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ciampo ciampo added the [Status] Blocked Used to indicate that a current effort isn't able to move forward label Sep 18, 2024
@ciampo
Copy link
Contributor

ciampo commented Sep 18, 2024

Let's wait before reviewing / merging this one until all usages of ButtonGroup have been removed in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Blocked Used to indicate that a current effort isn't able to move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants