Polish paddings, margins, headings #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves some CSS from the button component to the tools stylesheet. It's a better place. It also lightens the save state so it's the same color as everything else in the editor bar.
There were some offset here and there. This commit makes them 1:1 with the mockups, and also moves to using variables and a little SCSS math that should hopefully make the resulting positioning stuff a little easier to work with.
This tunes the margins a bit. It also resizes headings 1-6 a bit, so they are differentiated and all different. This fixes #625
mtias
added
[Feature] Blocks
mtias
reviewed
May 4, 2017
| @@ -0,0 +1,39 @@ | |||
| .editor-visual-editor__block[data-type="core/heading"] { | |||
There was a problem hiding this comment.
Seems this file is using spaces?
There was a problem hiding this comment.
Argh! I thought Atom would default to tabs in new files! Should be fixed now.
mtias
reviewed
May 4, 2017
| @@ -48,6 +48,10 @@ $admin-sidebar-width-big: 190px; | |||
| $admin-sidebar-width-collapsed: 36px; | |||
| $shadow-popover: 0px 3px 20px rgba( $dark-gray-900, .1 ), 0px 1px 3px rgba( $dark-gray-900, .1 ); | |||
|
|
|||
| /* Blocks */ | |||
| $block-padding: 14px; | |||
| $block-left-margin: 18px; | |||
There was a problem hiding this comment.
Is this about the mover? Should we call it that considering it may move to the right in RTL?
There was a problem hiding this comment.
Great point. Fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a number of little polish things: